[ATL-1141] Support for wildcard origins #629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umbynos
force-pushed
the
umbynos/add_origins
branch
from
20eb865 to
c1b9c9e
Compare
umbynos
commented
Mar 31, 2021
| @@ -327,7 +327,6 @@ func loop() { | |||
|
|
|||
| extraOrigins := []string{ | |||
| "https://create.arduino.cc", | |||
| "https://create-dev.arduino.cc", "https://create-intel.arduino.cc", | |||
There was a problem hiding this comment.
@endorama I removed these origins since they are old and rarely used, plus it's not good to have them hardcoded.
It's possible to add new origins using the origins filed in the config.ini file.
Just add your origins and separate them with ", "
There was a problem hiding this comment.
@umbynos is the description of the PR correct after the last changes?
eclipse1985
approved these changes
Mar 31, 2021
umbynos
added a commit
that referenced
this pull request
Mar 31, 2021
* remove old extraOrigins, they shouldn't be hardcoded * replaced github.com/itsjamie/gin-cors with a fork to support wildcard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
feature
At the moment the fellow colleagues form IoT Cloud every time they want to test a PR they have to modify
originsfield insideconfig.iniOne time modification in
config.inineeded, now theoriginsfield accepts the wildcard character.no